Fix usage of nested objects in environments #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for insomnia-storybook ready! Built with commit 4ca9b98 |
develohpanda
approved these changes
Jun 6, 2020
| environment: { | ||
| foo: 'parent', | ||
| ancestor: true, | ||
| }, |
There was a problem hiding this comment.
I wonder if this change is triggered by your IDE and not controlled by ESLint/prettier rules? It shouldn't happen now that there is one source of truth for linting everywhere.
| const rendered = await renderUtils.render('Hello {{ users[0].name }}!', { | ||
| users: [{ name: 'Niji' }], | ||
| }); | ||
| expect(rendered).toBe('Hello Niji!'); |
Comment on lines
+376
to
+379
| name: 'Grandparent', | ||
| type: models.requestGroup.type, | ||
| environment: { | ||
| users: [{ name: 'Mike' }, { name: 'Opender' }], |
| @@ -44,7 +44,7 @@ export async function buildRenderContext( | |||
| const ordered = orderedJSON.order( | |||
| rootEnvironment.data, | |||
| rootEnvironment.dataPropertyOrder, | |||
| JSON_ORDER_PREFIX, | |||
| JSON_ORDER_SEPARATOR, | |||
gschier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where object properties within arrays disappear.