Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent trailing punctuation in README lists. #2477

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Consistent trailing punctuation in README lists. #2477

merged 1 commit into from
Aug 3, 2020

Conversation

luanldt
Copy link
Contributor

@luanldt luanldt commented Aug 3, 2020

We need sync for all line. Dot or none, we can't do like that.

@luanldt
Add some dot at last line.
14eb255 
We need sync for all line. Dot or none, we can't do like that.
@netlify
Copy link

netlify bot commented Aug 3, 2020

Deploy preview for insomnia-storybook ready!

Built with commit 14eb255

https://deploy-preview-2477--insomnia-storybook.netlify.app

develohpanda
develohpanda approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@develohpanda develohpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

I looked at markdownlint to see if it could enforce this particular rule, among others. Sadly not, this is the only related rule I could find, but it applies to headings and not lists.

@develohpanda develohpanda changed the title Add some dot at last line. Consistent trailing punctuation in README lists. Aug 3, 2020
@develohpanda develohpanda merged commit 28c9cd2 into Kong:develop Aug 3, 2020
@luanldt
Copy link
Contributor Author

luanldt commented Aug 4, 2020 •
edited
Loading

Thank you! 😄

I looked at markdownlint to see if it could enforce this particular rule, among others. Sadly not, this is the only related rule I could find, but it applies to headings and not lists.

That's okay, I might be the one who enforced that rule for the team. Wish can help you. Until i understand source and develop i will do it.

@develohpanda
Copy link
Contributor

develohpanda commented Aug 4, 2020 •
edited
Loading

@luanldt Issues tagged with Good First Issue are a great starting point. Also, if you face any issues while developing, feel free to reach out to the community on Slack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develohpanda develohpanda develohpanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luanldt @develohpanda