Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e Core tests to PR workflow #2536

Merged
merged 25 commits into from
Aug 24, 2020
Merged

Add e2e Core tests to PR workflow #2536

merged 25 commits into from
Aug 24, 2020

Conversation

develohpanda
Copy link
Contributor

@develohpanda develohpanda commented Aug 20, 2020 •
edited
Loading

As per title.

Related to #2535

@netlify
Copy link

netlify bot commented Aug 20, 2020 •
edited
Loading

Deploy preview for insomnia-storybook ready!

Built with commit 1d618c7

https://deploy-preview-2536--insomnia-storybook.netlify.app

@develohpanda develohpanda changed the title Add spectron to PR workflow Add e2e Core tests to PR workflow for Windows and Mac Aug 24, 2020
@develohpanda develohpanda self-assigned this Aug 24, 2020
@develohpanda develohpanda marked this pull request as ready for review August 24, 2020 05:23
@develohpanda develohpanda added this to Needs Review ❤ in Insomnia Kanban Aug 24, 2020
@develohpanda develohpanda mentioned this pull request Aug 24, 2020
Closed
12 tasks
DMarby
DMarby reviewed Aug 24, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
packages/insomnia-smoke-test/spec.js Outdated Show resolved Hide resolved
packages/insomnia-app/scripts/release.js Outdated Show resolved Hide resolved
@develohpanda develohpanda mentioned this pull request Aug 24, 2020
Merged
@develohpanda develohpanda changed the title Add e2e Core tests to PR workflow for Windows and Mac Add e2e Core tests to PR workflow Aug 24, 2020
sonicyeti
sonicyeti approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@sonicyeti sonicyeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@develohpanda develohpanda merged commit deaded4 into develop Aug 24, 2020
Insomnia Kanban automation moved this from Needs Review ❤ to Done 🎉 Aug 24, 2020
@develohpanda develohpanda deleted the spectron-in-ci branch August 24, 2020 20:40
@Ganjahmanvenenodedios Ganjahmanvenenodedios mentioned this pull request Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMarby DMarby DMarby approved these changes

@sonicyeti sonicyeti sonicyeti approved these changes

Assignees

@develohpanda develohpanda

Labels
None yet
Projects
No open projects
Insomnia Kanban
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@develohpanda @DMarby @sonicyeti