Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate designer vs core e2e tests #2545

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Separate designer vs core e2e tests #2545

merged 3 commits into from
Aug 24, 2020

Conversation

develohpanda
Copy link
Contributor

@develohpanda develohpanda commented Aug 24, 2020 •
edited
Loading

What it says on the tin.

Also introduced modules/*, containing key selectors and functionality. This will make the writing of tests more understandable, for example:

image

Related to #2535

@develohpanda develohpanda self-assigned this Aug 24, 2020
@netlify
Copy link

netlify bot commented Aug 24, 2020

Deploy preview for insomnia-storybook ready!

Built with commit f0c4aa1

https://deploy-preview-2545--insomnia-storybook.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2020 •
edited
Loading

Deploy preview for insomnia-storybook ready!

Built with commit 858b945

https://deploy-preview-2545--insomnia-storybook.netlify.app

@develohpanda develohpanda added this to Needs Review ❤ in Insomnia Kanban Aug 24, 2020
@develohpanda develohpanda mentioned this pull request Aug 24, 2020
Closed
12 tasks
DMarby
DMarby approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@DMarby DMarby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍
I guess this needs to be rebased and updated to match the changes to the tests made in #2536 and #2544 once those are merged as well?

@develohpanda
Copy link
Contributor Author

Awesome 👍
I guess this needs to be rebased and updated to match the changes to the tests made in #2536 and #2544 once those are merged as well?

Yep, will need to resolve conflicts though they should not be major.

@develohpanda develohpanda merged commit 0319547 into develop Aug 24, 2020
Insomnia Kanban automation moved this from Needs Review ❤ to Done 🎉 Aug 24, 2020
@develohpanda develohpanda deleted the run-test-specific-to-application branch August 24, 2020 22:49
@Ganjahmanvenenodedios Ganjahmanvenenodedios mentioned this pull request Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMarby DMarby DMarby approved these changes

@sonicyeti sonicyeti sonicyeti approved these changes

Assignees

@develohpanda develohpanda

Labels
None yet
Projects
No open projects
Insomnia Kanban
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@develohpanda @DMarby @sonicyeti