Update pdfjs-dist

packages/insomnia-app/app/ui/components/viewers/response-pdf-viewer.js

@@ -1,7 +1,7 @@
 // @flow
 import * as React from 'react';
 import autobind from 'autobind-decorator';
-import PDF from 'pdfjs-dist/webpack';
+import * as PDF from 'pdfjs-dist/webpack';
 
 type Props = {
   body: Buffer,
@@ -36,15 +36,16 @@ class ResponsePDFViewer extends React.PureComponent<Props, State> {
       const containerWidth = container.clientWidth;
       const pdf = await PDF.getDocument({
         data: this.props.body.toString('binary'),
-      });
+      }).promise;
+
       for (let i = 1; i <= pdf.numPages; i++) {
         const page = await pdf.getPage(i);
         const density = window.devicePixelRatio || 1;
 
-        const { width: pdfWidth, height: pdfHeight } = page.getViewport(1);
+        const { width: pdfWidth, height: pdfHeight } = page.getViewport({ scale: 1 });
         const ratio = pdfHeight / pdfWidth;
         const scale = containerWidth / pdfWidth;
-        const viewport = page.getViewport(scale * density);
+        const viewport = page.getViewport({ scale: scale * density });
 
         // set canvas for page
         const canvas = document.createElement('canvas');
@@ -65,7 +66,7 @@ class ResponsePDFViewer extends React.PureComponent<Props, State> {
           viewport: viewport,
         };
 
-        page.render(renderContext);
+        await page.render(renderContext).promise;
       }
     }, 100);
   }

packages/insomnia-app/package.json

@@ -152,7 +152,7 @@
     "oauth-1.0a": "^2.2.2",
     "openapi-2-kong": "^2.2.22",
     "papaparse": "^5.2.0",
-    "pdfjs-dist": "^2.2.228",
+    "pdfjs-dist": "^2.5.207",
     "prop-types": "^15.6.1",
     "react": "^16.8.6",
     "react-animated-tree": "^1.0.10",

packages/insomnia-smoke-test/core/app.test.js

@@ -78,4 +78,19 @@ describe('Application launch', function() {
     const csvViewer = await debug.getCsvViewer(app);
     await expect(csvViewer.getText()).resolves.toBe('a b c\n1 2 3');
   });
+
+  it('sends PDF request and shows rich response', async () => {
+    // Cannot mock the pdf response using Prism because it is not yet supported
+    // https://github.com/stoplightio/prism/issues/1248#issuecomment-646056440
+    const pdfUrl = 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf';
+    await debug.workspaceDropdownExists(app);
+    await debug.createNewRequest(app);
+    await debug.typeUrl(app, pdfUrl);
+    await debug.clickSendRequest(app);
+
+    await debug.expect200(app);
+    const pdfCanvas = await debug.getPdfCanvas(app);
+    // Investigate how we can extract text from the canvas, or compare images
+    await expect(pdfCanvas.isExisting()).resolves.toBe(true);
+  });
 });

packages/insomnia-smoke-test/modules/debug.js

@@ -58,11 +58,20 @@ const getCsvViewer = async app => {
   return csvViewer;
 };
 
+const getPdfCanvas = async app => {
+  const pdfViewer = await app.client.react$('ResponsePDFViewer');
+  await pdfViewer.waitForDisplayed();
+  const canvas = await pdfViewer.$('.S-PDF-ID canvas');
+  await canvas.waitForDisplayed();
+  return canvas;
+};
+
 module.exports = {
   workspaceDropdownExists,
   createNewRequest,
   typeUrl,
   clickSendRequest,
   expect200,
   getCsvViewer,
+  getPdfCanvas,
 };