Update pdfjs-dist #2645
Merged
Update pdfjs-dist #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMarby
suggested changes
Sep 21, 2020
develohpanda
deleted the
feature/ins-127-pdf-preview-pane-broken-in-202040
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pdfjs-dist and fixes our usage to bring it in line with the interfaces in the latest version.
This PR also adds an E2E test, which currently loads this PDF. Adding in a mock PDF response through Prism wasn't working/isn't supported yet, and we may need to spin up our own local server to present mock data. We can remove this test if it becomes flaky.
Closes #2623