/ insomnia Public
Fix infinite request spinner when cancelling "Send and Download" #2721
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
We were hiding the spinner at the end of the
_handleSendAndDownloadRequestWithEnvironmentmethod. However, we
were exiting early we the user cancel the save dialog (L672).
To prevent that, I've moved the code in a finally block, therefore we make sure that the spinner will be hidden