Fix infinite request spinner when cancelling "Send and Download" #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiovaresco
force-pushed
the
fix/2718-infinite-request-spinner
branch
from
c6f31c2
to
37f08d4
Compare
develohpanda
approved these changes
Oct 15, 2020
jgiovaresco
force-pushed
the
fix/2718-infinite-request-spinner
branch
from
37f08d4
to
a4741e5
Compare
DMarby
approved these changes
Oct 16, 2020
We were hiding the spinner at the end of the _handleSendAndDownloadRequestWithEnvironment method. However, we were exiting early we the user cancel the save dialog (L672). To prevent that, I've moved the code in a finally block, therefore we make sure that the spinner will be hidden Closes Kong#2718
jgiovaresco
force-pushed
the
fix/2718-infinite-request-spinner
branch
from
a4741e5
to
604b76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hiding the spinner at the end of the
_handleSendAndDownloadRequestWithEnvironmentmethod. However, wewere exiting early we the user cancel the save dialog (L672).
To prevent that, I've moved the code in a finally block, therefore we make sure that the spinner will be hidden
Closes #2718
Before
After
