Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown closing early issue #5778

Merged
merged 1 commit into from Feb 16, 2023
Merged

Fix dropdown closing early issue #5778

merged 1 commit into from Feb 16, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Feb 14, 2023 •
edited

changelog(Fixes): Fixed an issue where some dropdown options no longer worked (e.g. deleting a folder, deleting request history, ...).

When we have an ItemContent/DropdownItem inside a DropdownSection and the item has both an onClick call and also a withPrompt property, we need to set the closeOnSelect={false} value on the parent Dropdown so it doesn't exit early when a prompt is opened.

Closes INS-2359

@filfreire filfreire requested a review from a team February 14, 2023 15:27
@filfreire filfreire self-assigned this Feb 14, 2023
gatzjames
gatzjames approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@filfreire filfreire merged commit 60fb214 into Kong:develop Feb 16, 2023
@filfreire filfreire deleted the fix/dropdown-closing-early branch February 16, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

Assignees

@filfreire filfreire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filfreire @gatzjames