Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown closing early issue #5778

Merged
merged 1 commit into from Feb 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -138,6 +138,7 @@ export const RequestGroupActionsDropdown = forwardRef<RequestGroupActionsDropdow
ref={dropdownRef}
onOpen={onOpen}
dataTestId={`Dropdown-${toKebabCase(requestGroup.name)}`}
closeOnSelect={false}
triggerButton={
<DropdownButton>
<i className="fa fa-caret-down" />
Expand Down
Expand Up @@ -177,6 +177,7 @@ export const ResponseHistoryDropdown = <GenericResponse extends Response | WebSo
ref={dropdownRef}
aria-label="Response history dropdown"
key={activeResponse ? activeResponse._id : 'n/a'}
closeOnSelect={false}
className={className}
triggerButton={
<DropdownButton className="btn btn--super-compact tall" title="Response history">
Expand Down
Expand Up @@ -408,6 +408,7 @@ export const SyncDropdown: FC<Props> = ({ vcs, workspace, project }) => {
style={{ marginLeft: 'var(--padding-md)' }}
className="wide tall"
onOpen={() => refreshVCSAndRefetchRemote()}
closeOnSelect={false}
isDisabled={initializing}
triggerButton={
currentBranch === null ?
Expand Down
1 change: 1 addition & 0 deletions packages/insomnia/src/ui/components/request-url-bar.tsx
Expand Up @@ -399,6 +399,7 @@ export const RequestUrlBar = forwardRef<RequestUrlBarHandle, Props>(({
ref={dropdownRef}
aria-label="Request Options"
onClose={handleSendDropdownHide}
closeOnSelect={false}
triggerButton={
<StyledDropdownButton
className="urlbar__send-context"
Expand Down
1 change: 1 addition & 0 deletions packages/insomnia/src/ui/components/settings/shortcuts.tsx
Expand Up @@ -56,6 +56,7 @@ export const Shortcuts: FC = () => {
<td className="text-right options" style={{ verticalAlign: 'middle' }}>
<Dropdown
aria-label='Select a mode'
closeOnSelect={false}
triggerButton={
<DropdownButton
removePaddings={false}
Expand Down