Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5969 cannot select base environment #5970

Merged
merged 5 commits into from
May 17, 2023
Merged

fix #5969 cannot select base environment #5970

merged 5 commits into from
May 17, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented May 16, 2023 •
edited
Loading

Closes #5969

changelog(Fixes): Fixed a regression where folks could no longer open the base environment on the Environments Editor

@filfreire filfreire requested a review from a team May 16, 2023 14:25
@filfreire filfreire changed the title fix #5960 cannot select base environment fix #5969 cannot select base environment May 16, 2023
@filfreire filfreire enabled auto-merge May 16, 2023 15:02
@filfreire filfreire force-pushed the fix/issue-5969-select-base-env branch from cd1996d to b4d63fe Compare May 16, 2023 21:31
@filfreire filfreire force-pushed the fix/issue-5969-select-base-env branch from b4d63fe to 4a3c244 Compare May 17, 2023 10:50
gatzjames
gatzjames approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the ts expect error by adding a check left a suggestion. Lgtm

packages/insomnia/src/ui/components/modals/workspace-environments-edit-modal.tsx Outdated Show resolved Hide resolved
@filfreire filfreire added this pull request to the merge queue May 17, 2023
@gatzjames gatzjames disabled auto-merge May 17, 2023 12:07
@filfreire filfreire removed this pull request from the merge queue due to a manual request May 17, 2023
filfreire and others added 3 commits May 17, 2023 13:24
@filfreire filfreire enabled auto-merge May 17, 2023 12:25
@filfreire filfreire added this pull request to the merge queue May 17, 2023
Merged via the queue into Kong:develop with commit 9d2bde7 May 17, 2023
@filfreire filfreire deleted the fix/issue-5969-select-base-env branch May 17, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatzjames gatzjames gatzjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open Base Environment
2 participants
@filfreire @gatzjames