Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #6334 updating requestgroup caused render error #6342

Merged

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Aug 21, 2023

changelog(Fixes): Fixed issue #6334 where a error was thrown when updating a Request Folder via its Settings.

Closes #6334

The way we were calling update request group (e.g. when renaming or moving a request folder, or changing its description) wasn't properly setup. This PR fixed that. Also added a test.

  • when moving a request group to another workspace, we need to either redraw the current workspace view or open the other workspace view, otherwise we still see the moved request on the sidebar

Pending problems

@filfreire filfreire requested a review from a team August 21, 2023 12:40
@filfreire filfreire force-pushed the fix/issue-6334-render-error-update-reqgroup branch from 7cc995b to 8b365e8 Compare August 21, 2023 15:16
@jackkav
Copy link
Contributor

jackkav commented Aug 21, 2023

We need to standardise on a update request convention. Thanks for the fix

@jackkav jackkav merged commit 59c07bc into Kong:develop Aug 22, 2023
7 checks passed
jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
* fix: Kong#6334 updating requestgroup caused render error

* add test

* fix rename

* redirect on move

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to render error when updating folder via settings
2 participants