feat(Global Environments): Introduce a new top level file type called global environments. #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatzjames
force-pushed
the
feat/global-env
branch
3 times, most recently
from
a20fd61
to
750f9c0
Compare
|
can you include some screen shots in the description please. I think the ux is a bit contentious. I would also like to see a clear the environment model addressing the current inconsistencies in order to code review this approach. |
gatzjames
force-pushed
the
feat/global-env
branch
3 times, most recently
from
7058467
to
0f08cd2
Compare
ihexxa
reviewed
Jun 13, 2024
| }; | ||
|
|
||
| export const scopeToBgColorMap: Record<string, string> = { | ||
| design: 'bg-[--color-info]', | ||
| collection: 'bg-[--color-surprise]', | ||
| 'mock-server': 'bg-[--color-warning]', | ||
| unsynced: 'bg-[--hl-md]', | ||
| environment: 'bg-[--color-font]', |
There was a problem hiding this comment.
nit: Should it be --color-font or color-bg?
There was a problem hiding this comment.
Yep it's correct we want the color-font for bg here. Agree that it's counter intuitive but there are cases were we need the font color as bg 🫣
gatzjames
force-pushed
the
feat/global-env
branch
2 times, most recently
from
f9653fd
to
b98088b
Compare
4 tasks
gatzjames
force-pushed
the
feat/global-env
branch
2 times, most recently
from
9113f83
to
40b0bea
Compare
ihexxa
reviewed
Jun 18, 2024
gatzjames
force-pushed
the
feat/global-env
branch
from
40b0bea
to
7ef6780
Compare
ihexxa
approved these changes
Jun 18, 2024
stefancruz
pushed a commit
to stefancruz/insomnia
that referenced
this pull request
Jun 30, 2024
… global environments. (Kong#7511) * add new workspace type 'environment' * new route for environments and set/get for them * update environment picker UI * update workspace environment modal ui to match env view * global environment request rendering * type checks * ui overflow fix * update e2e * auto-lint issue * type-checks * Update aria label * create env from project view * changes * save * environment picker component * update e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
environmentNext steps:
globalsAPI in pre-request/after-response scriptsNew Environment picker UI:
Global Environments in the Project view:
Updates to Models
environment