fixed the assignment of mocked log functions in plugin_test.js

[dwoctor]

I was writing tests for a Kong JS Plugin, and encountered Error: function kong.log.err is not a valid PDK function whenever the plugin tried to interact with await kong.log.err("insert-error-here");.

After looking into the code, I found the mockFunctions in plugin_test.js where assigned under the index not the value of the elements in logFunctions.

I traced the issue to the for-in loop the returning the index not the value of the elements of logFunctions.

In this PR the assignment has been changed to use the name and not the index by using a basic for loop.

I hope these changes are good enough to be merged into the mainline.
If not the feedback would be appreciated.

[dwoctor]

Looks like the 14.x build failed, any ideas on what the issue is?

[CLAassistant]

All committers have signed the CLA.

[dwoctor]

I ran npm test on my local machine with node v14.19.0, all the tests came back passed. Maybe it was a glitch in the CI runner?

[dwoctor]

I think the issue is occurring on line 28 of test not line 30 as the CI output suggests. It looks to be the test is acting a bit non deterministically in regards to the sleep.

kong-js-pdk/__tests__/pluing.test.js

Line 28 in e1e49be

expect(mod.getLastStartInstanceTime()).toBeGreaterThan(start)

[dwoctor]

I think if await sleep(1000) is moved from line 24 to above line 14 the inconsistency is removed. The issue is the plugin is executing immediately because and the sleep is in the wrong place to get the desired behaviour.

[dwoctor]

I have added the changes to the pluing.test.js as part of this PR. The changes moves the sleep from line 24 to below line 12.

[dwoctor]

I think I need a reapprove to get the CI runners going again.

[fffonion]

Looks good! Thanks for the quick fix for test as well! @dwoctor

[dwoctor]

@fffonion Thanks for approving and merging this change quickly. Is there going to be a release soon?

[fffonion]

I will create a patch release tomorrow @dwoctor , it will be 0.5.3.

[dwoctor]

@fffonion Thanks.

[fffonion]

@dwoctor it's now released!

[dwoctor]

@fffonion Thank you.