Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

**unknown-service-name** when integrate with Jaeger #12

Closed
longit644 opened this issue Jul 3, 2018 · 3 comments
Closed

**unknown-service-name** when integrate with Jaeger #12

longit644 opened this issue Jul 3, 2018 · 3 comments
Labels
Jaegar-Compat Issue only present when using Jaegar's zipkin compatibility mode

Comments

@longit644
Copy link
Contributor

No service name in UI Jaeger with spans from kong-plugin-zipkin.

Screenshot:
screen shot 2018-07-03 at 12 04 41 pm
@james-callahan james-callahan added the Jaegar-Compat Issue only present when using Jaegar's zipkin compatibility mode label Jul 4, 2018
@james-callahan
Copy link
Contributor

james-callahan commented Jul 5, 2018 •
edited

Is this because we don't currently send localEndpoint?

Possible information here: jaegertracing/jaeger#585

@james-callahan
Copy link
Contributor

james-callahan commented Jul 6, 2018 •
edited

Yes it is. providing

localEndpoint = {
	serviceName = "myservice";
};

fills in the field + doesn't cause errors in zipkin.

james-callahan added a commit that referenced this issue Jul 6, 2018
@james-callahan
kong/plugins/zipkin/reporter.lua: Use current kong service name as lo…
9c7de87 
…calEndpoint

Fixes #12
@longit644
Copy link
Contributor Author

👍

@goober goober mentioned this issue Feb 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Jaegar-Compat Issue only present when using Jaegar's zipkin compatibility mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longit644 @james-callahan