Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(handler) b3 single header #66

Merged
merged 3 commits into from
Feb 13, 2020
Merged

feat(handler) b3 single header #66

merged 3 commits into from
Feb 13, 2020

Conversation

kikito
Copy link
Member

@kikito kikito commented Feb 7, 2020

Implements #21

@kikito kikito changed the title Feat/b3 single header feat/b3 single header Feb 7, 2020
@kikito kikito changed the title feat/b3 single header feat(handler) b3 single header Feb 7, 2020
@codefromthecrypt
Copy link

I'd be happy to review, but it is easier on the eyes for me if some assertions are made with actual headers and anticipated results. ex pre-canned headers

https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java

this could be in addition to the integrated tests and just a suggestion.

@kikito
Copy link
Member Author

kikito commented Feb 11, 2020

@adriancole thanks for the suggestion. I have added some unit tests for the header parsing, which test all the new b3 single header cases more exhaustively, in isolation from the rest of the app.

@codefromthecrypt
Copy link

looks good thanks!

@kikito kikito merged commit b50600e into master Feb 13, 2020
@kikito kikito deleted the feat/b3-single-header branch February 13, 2020 17:09
@kikito kikito restored the feat/b3-single-header branch February 13, 2020 17:10
@kikito kikito deleted the feat/b3-single-header branch February 13, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants