fix(clean) run a prune command to clear the build cache #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not pruning the build cache, the next run will simply rebuild the images from the cache without actually rebuilding. In case of a `pongo clean` or `pongo nuke` that's not what we want.
This was referenced Dec 20, 2021
Tieske
added a commit
to Kong/kong
that referenced
this pull request
Dec 20, 2021
This fixes the deeper underlying problem related to Kong/kong-pongo#241 . In those cases the `make dev` overall failed because LuaRocks failed, but it was not signaled. Hence docker assumes the image to be valid and even caches the results of the docker commands. Despite them being faulty.
Tieske
added a commit
to Kong/kong
that referenced
this pull request
Dec 20, 2021
This fixes the deeper underlying problem related to Kong/kong-pongo#241 . In those cases the `make dev` overall failed because LuaRocks failed, but it was not signaled. Hence docker assumes the image to be valid and even caches the results of the docker commands. Despite them being faulty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not pruning the build cache, the next run will simply rebuild
the images from the cache without actually rebuilding. In case of
a
pongo cleanorpongo nukethat's not what we want.See #188 #94 #189