fix(versions): resolve EE-versions by the last 2 digits #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
fix/version-resolve
branch
2 times, most recently
from
6f0daca
to
4f6b22c
Compare
flrgh
reviewed
Dec 4, 2023
flrgh
approved these changes
Dec 4, 2023
Tieske
force-pushed
the
fix/version-resolve
branch
from
4f6b22c
to
6e0d1fe
Compare
flrgh
approved these changes
Dec 4, 2023
flrgh
reviewed
Dec 4, 2023
fffonion
approved these changes
Dec 5, 2023
outsinre
reviewed
Dec 5, 2023
outsinre
reviewed
Dec 5, 2023
Tieske
force-pushed
the
fix/version-resolve
branch
from
6e0d1fe
to
70055a7
Compare
That would be a breaking change for Pongo, so we should hold off on that. |
|
@curiositycasualty seems CI is failing on the new license stuff:
can you have a look if the secrets are available in this repo? |
curiositycasualty
force-pushed
the
fix/version-resolve
branch
from
70055a7
to
fdfdbad
Compare
Enterprise versions have pacth versions both on 3rd and 4th digit whilst resolving only took 4th into account. Eg. 3.4.1.x resolved to 3.4.1.1, whilst 3.4.2.0 is actually the latest
Tieske
force-pushed
the
fix/version-resolve
branch
from
fdfdbad
to
a803b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterprise versions have patch versions both on 3rd and 4th digit whilst resolving only took 4th into account. Eg. 3.4.1.x resolved to 3.4.1.1, whilst 3.4.2.0 is actually the latest within the 3.4 range.