Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Way to Use "#" in kong.conf File #2101

Closed
wojtek-oledzki opened this issue Feb 17, 2017 · 3 comments
Closed

No Way to Use "#" in kong.conf File #2101

wojtek-oledzki opened this issue Feb 17, 2017 · 3 comments
Assignees
Labels
task/needs-investigation Requires investigation and reproduction before classifying it as a bug or not.

Comments

@wojtek-oledzki
Copy link

Summary

You can not use "#" in kong.conf

Steps To Reproduce

  1. set pg_password to test#123
  2. restart kong

Additional Details & Logs

  • Kong version 0.9.*

https://github.com/Mashape/kong/blob/692caa9dc2db22f83743e63373da6fab45c174f4/kong/conf_loader.lua#L288

using trim_quotes might help.

@woledzki
Copy link

trim_quotes did not helped :D

Looks like a major limitation for kong (and pl.config)

@subnetmarco
Copy link
Member

@woledzki seems like this has been fixed in 0.10 by updating the penlight library to latest.

@thibaultcha thibaultcha added the task/needs-investigation Requires investigation and reproduction before classifying it as a bug or not. label Feb 28, 2017
@p0pr0ck5 p0pr0ck5 self-assigned this Apr 17, 2017
@p0pr0ck5
Copy link
Contributor

Doesn't look like a Penlight issue, but rather how we treated octothorpes (assuming all characters following one are comments). We can ammend this behavior by allowing escaped octothorpes in config directives (e.g. test\#123)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task/needs-investigation Requires investigation and reproduction before classifying it as a bug or not.
Projects
None yet
Development

No branches or pull requests

5 participants