Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config) allow octothorpes in config directives #2411

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

p0pr0ck5
Copy link
Contributor

Summary

Previously we treated all tokens after a comment character (#)
as comments. This commit updates this behavior to recognize escaped
octothorpes as literal characters, and adjusted the directive
appropriately.

Full changelog

  • feat(config) allow octothorpes in config directives

Issues resolved

Fix #2101

Previously we treated all tokens after a comment character ("#")
as comments. This commit updates this behavior to recognize escaped
octothorpes as literal characters, and adjusted the directive
appropriately.
Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants