chore(admin): remove /plugins/schema/:name #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary The /plugins/schema/:name was marked for removal in 3.0 but for some reason we forgot to do it. Doing it now. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
chore/api-remove-deprecated
branch
from
494fb81
to
945fb17
Compare
hanshuebner
approved these changes
May 11, 2023
czeslavo
added a commit
to Kong/go-kong
that referenced
this pull request
May 15, 2023
The GET /plugins/schema/<pluginName> endpoint that GetSchema was using has been recently removed in Kong/kong#10846.
3 tasks
kikito
added a commit
that referenced
this pull request
Jul 27, 2023
Partially reverts #10846 Even though we have been emitting deprecation warnings when the endpoint was used, we didn't remove it in 3.0, and doing it now can be a surprise breaking change for someone. In fact, someone had to update a project which was relying on that path, that is linked in #10846 This reverts the removal and replaces the deprecation version with 4.0 instead of 3.0. This PR does not revert the changes in our tests to use the new endpoint instead of the deprecated one.
flrgh
pushed a commit
that referenced
this pull request
Jul 28, 2023
Partially reverts #10846 Even though we have been emitting deprecation warnings when the endpoint was used, we didn't remove it in 3.0, and doing it now can be a surprise breaking change for someone. In fact, someone had to update a project which was relying on that path, that is linked in #10846 This reverts the removal and replaces the deprecation version with 4.0 instead of 3.0. This PR does not revert the changes in our tests to use the new endpoint instead of the deprecated one.
team-gateway-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
Partially reverts #10846 Even though we have been emitting deprecation warnings when the endpoint was used, we didn't remove it in 3.0, and doing it now can be a surprise breaking change for someone. In fact, someone had to update a project which was relying on that path, that is linked in #10846 This reverts the removal and replaces the deprecation version with 4.0 instead of 3.0. This PR does not revert the changes in our tests to use the new endpoint instead of the deprecated one. (cherry picked from commit 1ec4d73)
flrgh
pushed a commit
that referenced
this pull request
Jul 28, 2023
Partially reverts #10846 Even though we have been emitting deprecation warnings when the endpoint was used, we didn't remove it in 3.0, and doing it now can be a surprise breaking change for someone. In fact, someone had to update a project which was relying on that path, that is linked in #10846 This reverts the removal and replaces the deprecation version with 4.0 instead of 3.0. This PR does not revert the changes in our tests to use the new endpoint instead of the deprecated one. (cherry picked from commit 1ec4d73) Co-authored-by: Enrique García Cota <kikito@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The /plugins/schema/:name was marked for removal in 3.0 but for some reason we forgot to do it. Doing it now.