fix(aws-lambda): lazily initialize aws library #11614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Lazily initializes AWS library on a first use, to remove startup delay caused by AWS metadata discovery. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
fix/aws-lazy-load
branch
from
fb7a5e3
to
9f4fa97
Compare
windmgc
reviewed
Sep 20, 2023
|
Why don't we need a change log? |
Because it is fix over to upcoming unreleased feature THAT already has a changelog, So you can think that there was nothing to fix if this was originally in the original PR. It would be strange if changelog says that we 1) added new feature and 2) fixed it. We can say that we added new feature and be done with it (we didn't fix anything for anyone as nobody is using new feature as it is not released - the audience of changelogs is our users, not us - at least the primary audience). |
3 tasks
hanshuebner
approved these changes
Sep 20, 2023
windmgc
pushed a commit
that referenced
this pull request
Nov 2, 2023
### Summary Lazily initializes AWS library on a first use, to remove startup delay caused by AWS metadata discovery. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
3 tasks
windmgc
pushed a commit
that referenced
this pull request
Nov 3, 2023
### Summary Lazily initializes AWS library on a first use, to remove startup delay caused by AWS metadata discovery. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lazily initializes AWS library on a first use, to remove startup delay caused by AWS metadata discovery.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.md^ this PR does not need any of those, this is on top of unreleased feature.