improved versions checks on OpenResty and Serf #1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new UNIX configuration file - defaults are stored in a Lua module - on/off/true/false alias for booleans - overriding rules with precedence - defaults - file-level - ENV variables (prefixed by KONG_) - custom from Lua table (loader argument) - testing configuration - new nginx and ngx_lua configuration properties
- start as the previous CLI - init_by_lua to migrate when Kong is running 'embedded' in a custom nginx instance
new syslog logging for reports uses ngx_lua UDP sockets, also usable in CLI since resty is the new interpreter.
- We were making too many full migrations in the tests, considerably slowing down Cassandra testing, unecessarily because the same behavior was being tested several times. - Cassandra DAO tests now use 'kong_tests' by default
| offset = offset, | ||
| ["next"] = next_url, | ||
| } | ||
| end |
There was a problem hiding this comment.
object calisthenics says we can/should avoid this else
result = {
data = rows,
total = total_count,
offset = offset,
["next"] = next_url,
}
if #rows == 0 then
result = [[{"data":[],"total":0}]]
end
There was a problem hiding this comment.
It would create a table, which is immediately disposed of again. Current code is more performant.
There was a problem hiding this comment.
interesting result isn't just a variable?
There was a problem hiding this comment.
result is just a variable, but when assigning { data = rows, .... } a new table is created (the outer curly braces in this construct)
|
Please rebase on refactor/cli (which was rebased on next) |
|
replaced by #1307 |
Tieske
added a commit
that referenced
this pull request
Jul 1, 2016
Tieske
added a commit
that referenced
this pull request
Jul 1, 2016
* add better version information, replaces PR #1221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1212, #946 and #947
adds versions checks, for Serf and Nginx, against branch
refactor/cliNote: dnsmasq is absent now, so no checks against that dependency.