feat(cli) better version information for dependency binaries #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.debug("%s: '%s'", cmd, stderr:sub(1, -2)) | ||
| local version_match = stderr:match(nginx_version_pattern) | ||
| if (not version_match) or (not nginx_compatible:matches(version_match)) then | ||
| return nil, "Incompatible nginx found. Kong requires OpenResty, version "..tostring(nginx_compatible) .. |
There was a problem hiding this comment.
Please do not capitalize error messages here to stay consistent with other errors in the CLI and respect the punctuation when thy are printed to the user ("Error: ...").
Ditto for the other 2-3 occurrences in this changelog
There was a problem hiding this comment.
Also: the shorter the better
|
de-capitalized |
thibaultcha
changed the title
|
Could you rebase your changes on the latest |
Tieske
force-pushed
the
refactor/version-info
branch
from
b23e0a3
to
4c3ced5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1221