Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): add preserve_host logic in stream subsystem #12261

Merged
merged 10 commits into from Dec 29, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 28, 2023

Summary

It is a succeeding of #12127.

  • add paths = { "/" } in routes to enable calculation cache for path
  • add perserve_host logic for stream

KAG-3032

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as draft December 29, 2023 04:50
@chronolaw
Copy link
Contributor Author

It will be replaced by #12268 .

@chronolaw chronolaw changed the title tests(router): fix test cases which are incompitible with new router cache algorithm fix(router): add preserve_host logic in stream subsystem Dec 29, 2023
@chronolaw chronolaw marked this pull request as ready for review December 29, 2023 06:53
@dndx dndx merged commit 86f0a6c into master Dec 29, 2023
29 checks passed
@dndx dndx deleted the tests/fix_atc_router_cache branch December 29, 2023 06:57
@StarlightIbuki StarlightIbuki added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 2, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12261-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12261-to-master-to-upstream
git checkout -b cherry-pick-12261-to-master-to-upstream
ancref=$(git merge-base 8c2b5a4e7a35da88bbbd5b78507b8a292597d420 943ea268e2dc03c71124a98921590d6a298ecb5f)
git cherry-pick -x $ancref..943ea268e2dc03c71124a98921590d6a298ecb5f

@chronolaw chronolaw removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 2, 2024
dndx pushed a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants