Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): revert dynamic test scheduler and fix tests #12268

Merged
merged 4 commits into from Dec 29, 2023
Merged

chore(ci): revert dynamic test scheduler and fix tests #12268

merged 4 commits into from Dec 29, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 29, 2023 •
edited

Summary

revert #12180, #12254, fix tests of #12127.

KAG-3451

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Dec 29, 2023
@StarlightIbuki StarlightIbuki force-pushed the chore/revert_dynamic_test_scheduler branch from 94d83c0 to 85728d4 Compare December 29, 2023 03:31
@StarlightIbuki StarlightIbuki marked this pull request as ready for review December 29, 2023 03:59
@StarlightIbuki StarlightIbuki force-pushed the chore/revert_dynamic_test_scheduler branch from 85728d4 to 24cf9dc Compare December 29, 2023 03:59
@chronolaw chronolaw force-pushed the chore/revert_dynamic_test_scheduler branch from 24cf9dc to 5c93056 Compare December 29, 2023 04:01
@StarlightIbuki StarlightIbuki force-pushed the chore/revert_dynamic_test_scheduler branch from 5c93056 to 24cf9dc Compare December 29, 2023 04:03
@chronolaw chronolaw mentioned this pull request Dec 29, 2023
Merged
3 tasks
@chronolaw chronolaw changed the title chore(ci): try to revert dynamic test scheduler chore(ci): revert dynamic test scheduler and fix tests Dec 29, 2023
@StarlightIbuki StarlightIbuki force-pushed the chore/revert_dynamic_test_scheduler branch from 2de76d8 to c9499eb Compare December 29, 2023 06:12
@tzssangglass tzssangglass mentioned this pull request Dec 29, 2023
Closed
3 tasks
@StarlightIbuki StarlightIbuki force-pushed the chore/revert_dynamic_test_scheduler branch from c9499eb to 5ba5873 Compare December 29, 2023 07:03
StarlightIbuki
StarlightIbuki approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve given the CI pass.

chronolaw and others added 4 commits December 29, 2023 03:28
@chronolaw @dndx
chore(actions): revert dynamic test scheduler (#12180)
298e928 
Due to false green observed on `master`.
@chronolaw @dndx
tests(plugins): fix previous master test failures
30ddb49 
Fix `03-http-log/01-log_spec.lua`
Fix `13-cors/01-access_spec.lua`
Fix `spec/03-plugins/03-http-log/01-log_spec.lua`
@chronolaw @dndx
tests(admin-api): change OpenSSL error message to ones from the new v…
12a26db 
…ersion
@StarlightIbuki @dndx
Revert "feat(templates): enable status_listen by default on localho…
f4ddca2 
…st (#12254)"

This reverts commit 1ab6ead.
The CI did not alert because of the scheduler's bug
@dndx dndx force-pushed the chore/revert_dynamic_test_scheduler branch from 18f42b0 to f4ddca2 Compare December 29, 2023 11:30
@dndx dndx merged commit a45112f into master Dec 29, 2023
24 checks passed
@dndx dndx deleted the chore/revert_dynamic_test_scheduler branch December 29, 2023 16:25
@ADD-SP ADD-SP mentioned this pull request Jan 2, 2024
Merged
2 tasks
@chronolaw chronolaw mentioned this pull request Jan 10, 2024
Merged
1 task
@samugi samugi mentioned this pull request Jan 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

Assignees

@chronolaw chronolaw

Labels
chore Not part of the core functionality of kong, but still needed core/router core/templates size/XL skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chronolaw @dndx @StarlightIbuki