Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emmy-lua-debugger): support busted & multi worker debugging + docs #13071

Merged
merged 2 commits into from
May 27, 2024

Conversation

hanshuebner
Copy link
Contributor

@hanshuebner hanshuebner commented May 23, 2024

Summary

Support debugging of busted tests with EmmyLua. Debugging busted tests is controlled by a separate set of environment variables to not interfere with debugging Kong Gateway itself. This PR also enables debugging multiple workers and adds more documentation.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4584

@github-actions github-actions bot added core/docs cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 23, 2024
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I tested it and it worked perfectly

bin/busted Outdated
host = os.getenv("BUSTED_EMMY_DEBUGGER_HOST"),
port = os.getenv("BUSTED_EMMY_DEBUGGER_PORT"),
wait = true,
log = function (_, message) print(message) end,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed.

@hanshuebner hanshuebner marked this pull request as ready for review May 27, 2024 08:55
@hanshuebner hanshuebner merged commit ecf4314 into master May 27, 2024
25 checks passed
@hanshuebner hanshuebner deleted the feat/debug-busted branch May 27, 2024 10:14
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/docs size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants