Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdk): add zero value to support unlimited body size #13431

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat(pdk): add zero value to support unlimited body size #13431

merged 4 commits into from
Aug 2, 2024

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon commented Jul 29, 2024 •
edited
Loading

It is the cherry-pick of kong/kong-ee#9472.

KAG-4698

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 29, 2024
chronolaw
chronolaw reviewed Jul 30, 2024
View reviewed changes
changelog/unreleased/kong/feat-pdk-unlimited-body-size.yml Outdated Show resolved Hide resolved
kong/pdk/request.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw marked this pull request as ready for review July 30, 2024 03:45
chronolaw
chronolaw reviewed Jul 30, 2024
View reviewed changes
kong/pdk/request.lua Outdated Show resolved Hide resolved
@chronolaw
Copy link
Contributor

If now we are using 0 for no limit, could you change the title of this PR?

@ADD-SP ADD-SP changed the title feat(pdk): add negative value to support unlimited body size feat(pdk): add zero value to support unlimited body size Aug 2, 2024
@ADD-SP ADD-SP dismissed their stale review August 2, 2024 06:10

My mistake

@ADD-SP ADD-SP merged commit 4a3dacf into master Aug 2, 2024
27 checks passed
@ADD-SP ADD-SP deleted the pdk_unlimited_body_size branch August 2, 2024 06:13
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@Water-Melon Water-Melon

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Water-Melon @chronolaw @team-gateway-bot @ADD-SP