fix(cli) prevent start from stopping already-running Kong #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a check ensuring Kong (Nginx) is not running even before executing the prefix_handler, which would maybe have consequences such as re-generating SSL certs, or running migrations, etc... * add a test for this behavior * error now says "Kong is already running" instead of "Nginx is already running", which is also probably more elegant.
thibaultcha
force-pushed
the
fix/start-stopping-alread-running
branch
from
86b86e4
to
3673504
Compare
Tieske
approved these changes
Sep 15, 2016
|
lgtm, pending the tests... |
thibaultcha
added
pr/ready (but hold merge)
|
Hi guys and thanks for fixing this. Any idea when this will see release? I'm running |
|
@lsh-0 It's scheduled for 0.10 for which a first release candidate already is overdue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the prefix_handler, which would maybe have consequences such as
re-generating SSL certs, or running migrations, etc...
running", which is also probably more elegant.