feat(cors) allow for multiple origins #2203
Merged
+212
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
changed the title
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
0553daf
to
e189da1
Compare
|
👍 |
p0pr0ck5
previously approved these changes
Mar 14, 2017
kong/plugins/cors/handler.lua
Outdated
| "jo") | ||
| if err then | ||
| ngx.log(ngx.ERR, "[cors] could not search for domain: ", err) | ||
| return |
There was a problem hiding this comment.
strictly speaking, this return here seems unnecessary- even if one regex call failed, perhaps others could succeed
kong/plugins/cors/handler.lua
Outdated
| return | ||
| end | ||
|
|
||
| local req_origin = req_get_headers()["origin"] |
There was a problem hiding this comment.
using ngx.var as opposed to get_headers would possibly be more performant here
|
Also looks like the rockspec is missing the migrations files. |
|
Indeed! That's missing from the rockspec tests... |
p0pr0ck5
dismissed
their stale review
Removing approval- rockspec should be updated to include migrations files so unit tests pass
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
e189da1
to
34499de
Compare
|
Updated . |
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
34499de
to
eb3136b
Compare
p0pr0ck5
approved these changes
Mar 14, 2017
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
eb3136b
to
f9cf0a9
Compare
thibaultcha
changed the title
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
f9cf0a9
to
574cc69
Compare
* renamed `origin` field to `origins` * provide migrations for datastore * use PCRE API for multiple origin matching * fix compatibility with current upstream changes ensuring "*" support * minor style updates * minor perf updates
thibaultcha
force-pushed
the
feat/cors-multiple-origins
branch
from
574cc69
to
76d0f12
Compare
thibaultcha
added
pr/ready (but hold merge)
|
Guys, cannot wait to use it already, just cut the right time since we are extending our web services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated PR to handle multiple origins in the CORS plugin.
Full changelog
origintoorigins, which allows a list of origins*being configured forconf.originsandAllow-CredentialsIssues resolved
Replace #1774
Replace #1973
Fix #1043
TODO