[feature] new array type for schema fields

[thibaultcha]

• Useful for lists such as {"apikey", "key"}
• Can be aliased to a comma-separated string: "apikey,key"

In form-encoded mode (JSON would be a real array), the Admin API accepts the following:

$ curl --url http://localhost:8001/apis/mockbin/plugins \
  -d "name=keyauth" \
  -d "value.key_names[1]=apikey" \
  -d "value.key_names[2]=key"

Or:

$ curl --url http://localhost:8001/apis/mockbin/plugins \
  -d "name=keyauth" \
  -d "value.key_names=apikey,key"

[subnetmarco]

So both formats will be supported?

[thibaultcha]

That's what it says

[subnetmarco]

It should also work for multipart/form-data requests. Support for multipart is already there, just make sure it works with:

curl --url http://localhost:8001/apis/mockbin/plugins \
  -F "name=keyauth" \
  -F "value.key_names[1]=apikey" \
  -F "value.key_names[2]=key"

and

curl --url http://localhost:8001/apis/mockbin/plugins \
  -F "name=keyauth" \
  -F "value.key_names=apikey,key"

[thibaultcha]

That type of parsing happens on the Lapis side, so I'll try but it should work.

[subnetmarco]

Back in the days I had to add this to support multipart/form-data: https://github.com/Mashape/kong/blob/master/kong/api/routes/base_controller.lua#L54-L56

Because for multipart data Lapis creates a table, and the value is stored inside of .content.

[thibaultcha]

btw supporting application/json and x-www-form-urlencoded is also perfectly fine...

[subnetmarco]

I need multipart for the SSL plugin, so the users can upload their certificates