Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps) lock OpenResty compat. to 1.11.2.4 #2790

Merged
merged 1 commit into from
Aug 10, 2017
Merged

chore(deps) lock OpenResty compat. to 1.11.2.4 #2790

merged 1 commit into from
Aug 10, 2017

Conversation

thibaultcha
Copy link
Member

No description provided.

kikito
kikito approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment after grepping: The UPGRADING.md file mentions "The preferred version of OpenResty is now 1.11.2.2". Maybe we should reword it to "The preferred version of OpenResty for kong 0.10 is 1.11.2.2". Other than that, this looks ok to me.

@kikito kikito added the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label Aug 10, 2017
@thibaultcha
Copy link
Member Author

@kikito Yes, the Changelog and the Upgrade Path will be updated in a separate commit with the proper scope! Thanks!

@thibaultcha thibaultcha merged commit 445b6e5 into release/0.11 Aug 10, 2017
@thibaultcha thibaultcha deleted the chore/deps-lock-openresty-compat branch August 10, 2017 19:59
thibaultcha added a commit that referenced this pull request Aug 11, 2017
@thibaultcha
chore(deps) lock OpenResty compat. to 1.11.2.4 (#2790)
7af730c
thibaultcha added a commit that referenced this pull request Aug 16, 2017
@thibaultcha
chore(deps) lock OpenResty compat. to 1.11.2.4 (#2790)
f2dedb0
kikito pushed a commit that referenced this pull request Aug 16, 2017
@thibaultcha @kikito
chore(deps) lock OpenResty compat. to 1.11.2.4 (#2790)
0e41bf0
@JnMik JnMik mentioned this pull request Sep 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikito kikito kikito approved these changes

Assignees
No one assigned
Labels
pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultcha @kikito