Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli) fix log to forceful shutdown #3061

Merged
merged 1 commit into from
Dec 1, 2017
Merged

fix(cli) fix log to forceful shutdown #3061

merged 1 commit into from
Dec 1, 2017

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 30, 2017

The cli QUIT command would even on a forceful exit still print a 'graceful' message.

the cli QUIT command would even on a forceful exit still
print a 'graceful' message.
Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unfortunately we don't have tests for this code path...

@thibaultcha thibaultcha merged commit c0745c5 into master Dec 1, 2017
@thibaultcha thibaultcha deleted the fix/quit-log branch December 1, 2017 22:44
p0pr0ck5 pushed a commit that referenced this pull request Dec 2, 2017
The CLI `quit` command would even on a forceful exit still
print a 'graceful shutdown' message.

From #3061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants