fix(dao) cassandra boolean serialization #3362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize boolean values.
|
I think an integration test in the DAO or Admin API suite would be appropriate? |
gszr
force-pushed
the
fix/cassandra-boolean-serialization
branch
2 times, most recently
from
0cd030b
to
63cea74
Compare
gszr
force-pushed
the
fix/cassandra-boolean-serialization
branch
from
63cea74
to
e66136a
Compare
thibaultcha
pushed a commit
that referenced
this pull request
Apr 3, 2018
Queries filtering on boolean values would result in an error. At the admin API level, this can be reproduced by issuing a request that filters on a boolean field - e.g., GET /apis?preserve_host=false, which will result in a 500 response. From #3362 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
|
Manually merged, thank you! |
kikito
pushed a commit
to kikito/kong
that referenced
this pull request
Apr 10, 2018
Queries filtering on boolean values would result in an error. At the admin API level, this can be reproduced by issuing a request that filters on a boolean field - e.g., GET /apis?preserve_host=false, which will result in a 500 response. From Kong#3362 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correctly serialize boolean values in Cassandra.
Issues resolved
Queries filtering on boolean values would result in an error. At the admin API level, this can be reproduced by issuing a request that filters on a boolean field - e.g.,
GET /apis?preserve_host=false, which will result in a 500 response.