fix(balancer) avoid needless rebuild of balancer when adding target #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced when the loop to find `last_equal_index` was changed from looping the new targets list into looping the old targets list. Looping the old targets list is more efficient, but the logic for checking the index needed to be updated. Includes a regression test that verifies that adding a target works and does not rebuild the balancer.
Tieske
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced when the loop to find
last_equal_indexwas changed from looping the new targets list into looping the old targets list. Looping the old targets list is more efficient, but the logic for checking the index needed to be updated.Includes a regression test that verifies that adding a target works and does not rebuild the balancer.