fix(request-termination) delayed response #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/request-termination-delayed
branch
2 times, most recently
from
b924ea2
to
50dbf40
Compare
thibaultcha
requested changes
Jun 5, 2018
| return ngx.exit(status_code) | ||
| else | ||
| return responses.send(status_code, message) | ||
| coroutine.yield() |
There was a problem hiding this comment.
Same comment as the azure-functions plugin
|
|
||
| else | ||
| ngx.header[constants.HEADERS.SERVER] = nil | ||
| end |
There was a problem hiding this comment.
This plugin should already have tests ensuring that this header is set/unset when terminating a request, and I am not seeing them. Perhaps this underlying implementation change warrants adding those tests.
bungle
force-pushed
the
fix/request-termination-delayed
branch
from
50dbf40
to
32658da
Compare
bungle
force-pushed
the
fix/request-termination-delayed
branch
4 times, most recently
from
226f7fe
to
4e3d7ad
Compare
bungle
force-pushed
the
fix/request-termination-delayed
branch
from
4e3d7ad
to
55d0479
Compare
thibaultcha
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
request-terminationdelayed response