[feature] implement wildcard subdomains for APIs' public_dns #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feature/wildcard-subdomains
branch
from
6407f52
to
7124c5d
Compare
| -- If the API was not found in the dictionary, maybe it is a wildcard public_dns. | ||
| -- In that case, we need to loop over all of them. | ||
| for _, wildcard_dns in ipairs(apis_dics.wildcard_dns) do | ||
| print("--------------------------------------------------------") |
An API's `public_dns` can now contain one '*' at the start or at the end of the string, and on a dot border (same rules as http://nginx.org/en/docs/http/server_names.html#wildcard_names). If so, it will get special treatment during the lookup and the resolver will try to match any given `Host` header against all wildcard public_dns. We keep things efficient by guaranteeing O(1) lookup for non wildcard public_dns. Only wildcard public_dns and paths will be O(n). Implements #297.
thibaultcha
force-pushed
the
feature/wildcard-subdomains
branch
from
7124c5d
to
ef34bc1
Compare
|
👍 |
thibaultcha
added
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Jul 9, 2015
[feature] implement wildcard subdomains for APIs' public_dns
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] implement wildcard subdomains for APIs' public_dns Former-commit-id: a66441044105d0a70ede72c708dc381efa370da1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An API's
public_dnscan now contain one '*' at the start or at the end of the string, and on a dot border (same rules as http://nginx.org/en/docs/http/server_names.html#wildcard_names).If so, it will get special treatment during the lookup and the resolver will try to match any given
Hostheader against all wildcardpublic_dns.We keep things efficient by guaranteeing O(1) lookup for non wildcard
public_dns. Only wildcardpublic_dnsandpathswill be O(n).Implements #297.