Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db) Fix incorrect check for primary key violations under cassandra #3865

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@james-callahan
Copy link
Contributor

commented Oct 18, 2018

The old code would never throw a primary key violation.

@james-callahan james-callahan requested a review from thibaultcha Oct 18, 2018

@james-callahan james-callahan force-pushed the james-callahan:fix/cassandra-pk branch from 2114cfb to b0aa0c2 Oct 18, 2018

@bungle

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

Great catch! Is there any possibility to make a test for it?

@james-callahan

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2018

Is there any possibility to make a test for it?

There is a test that relies on this behaviour in my ca-bootstrap branch.
I guess we could pick an existing dao item and write a test for it if you'd like?

@bungle

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

@james-callahan sounds like a plan! Yes, lets have official test for it so that we don't hit this again without noticing.

@james-callahan james-callahan force-pushed the james-callahan:fix/cassandra-pk branch from b0aa0c2 to ff9c5a2 Oct 19, 2018

@james-callahan james-callahan changed the base branch from next to master Oct 19, 2018

@james-callahan james-callahan force-pushed the james-callahan:fix/cassandra-pk branch from ff9c5a2 to dfae3ee Oct 19, 2018

@thibaultcha thibaultcha merged commit 1e60f27 into Kong:master Oct 19, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@james-callahan james-callahan deleted the james-callahan:fix/cassandra-pk branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.