Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db) Fix incorrect check for primary key violations under cassandra #3865

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

james-callahan
Copy link
Contributor

The old code would never throw a primary key violation.

@bungle
Copy link
Member

bungle commented Oct 18, 2018

Great catch! Is there any possibility to make a test for it?

@james-callahan
Copy link
Contributor Author

Is there any possibility to make a test for it?

There is a test that relies on this behaviour in my ca-bootstrap branch.
I guess we could pick an existing dao item and write a test for it if you'd like?

@bungle
Copy link
Member

bungle commented Oct 18, 2018

@james-callahan sounds like a plan! Yes, lets have official test for it so that we don't hit this again without noticing.

@thibaultcha thibaultcha merged commit 1e60f27 into Kong:master Oct 19, 2018
@james-callahan james-callahan deleted the fix/cassandra-pk branch October 19, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants