hotfix(db) ensure an empty JSON array is returned when no targets #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an upstream is created and no targets are added, `GET
/upstreams/:upstream/targets` should return an empty `data` JSON property
in the response as an array.
This change ensure an empty JSON array(`[]`) is returned and not an
empty object(`{}`).
A regression test has been added to ensure we catch this for endpoints:
- `/upstreams/:upstream/targets`
- `/upstreams/:upstream/targets/all`
Fix Kong#4043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an upstream is created and no targets are added,
GET /upstreams/:upstream/targetsshould return an emptydataJSON propertyin the response as an array.
This change ensure an empty JSON array(
[]) is returned and not anempty object(
{}).A regression test has been added to ensure we catch this for endpoints:
/upstreams/:upstream/targets/upstreams/:upstream/targets/allFix #4043