Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix/analytics] more robust buffer #471

Merged
merged 2 commits into from
Aug 13, 2015
Merged

Conversation

thibaultcha
Copy link
Member

  • Fix a critical issue where the buffer was not flushing itself when
    reaching the max size (in bytes).
  • Better logging in case of refused batch (number of items, size of the
    batch).
  • Dropping of the batch if it is refused by the socket server (HTTP
    400).
  • If a batch is not accepted for another reason, it is now pushed to the
    end of the queue instead of keeping blocking it.
  • Dropping single ALF objects that exceed the max bytes size by
    themselves.
  • Tests for size limit reaching.

@thibaultcha thibaultcha force-pushed the hotfix/mashape-analytics branch 3 times, most recently from c823edf to 896dcb7 Compare August 12, 2015 20:28
- Fix a critical issue where the buffer was not flushing itself when
  reaching the max size (in bytes).
- Better logging in case of refused batch (number of items, size of the
  batch).
- Dropping of the batch if it is refused by the socket server (HTTP
  400).
- If a batch is not accepted for another reason, it is now pushed to the
  **end** of the queue instead of keeping blocking it.
- Dropping single ALF objects that exceed the max bytes size by
  themselves.
- Retry timer now waits 2 seconds.
- Tests for size limit reaching.
@thibaultcha thibaultcha added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Aug 13, 2015
thibaultcha added a commit that referenced this pull request Aug 13, 2015
[hotfix/analytics] more robust buffer
@thibaultcha thibaultcha merged commit 43f9c11 into master Aug 13, 2015
@thibaultcha thibaultcha deleted the hotfix/mashape-analytics branch August 13, 2015 22:11
ctranxuan pushed a commit to streamdataio/kong that referenced this pull request Aug 25, 2015
[hotfix/analytics] more robust buffer

Former-commit-id: 2c9ae153921962683cab1e3149b6c91e9fe28da3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant