Added authenticated_userid to password grant #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The password grant did not save the authenticated_userid before (nil). Without this information the resource server will not be able to perform authorization on the user. I'm pretty sure the client credential grant should also try and save the authenticated_userid if provided, but as it does not check for I'm not lua guy I would let someone else have a look at that part.
|
This actually is a major blocage right now for the usage of the oauth plugin as, as far as I can tell, we cannot pin point the user linked to a request |
subnetmarco
added a commit
that referenced
this pull request
Aug 21, 2015
…rid_fix Added authenticated_userid to password grant
|
You are correct and it's a bug. Thanks for fixing it. |
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
…_userid_fix Added authenticated_userid to password grant Former-commit-id: 73e1f99de1af38455f8dcf26f32ef8d20b066501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password grant did not save the authenticated_userid before (nil). Without this information the resource server will not be able to perform authorization on the user.
I'm pretty sure the client credential grant should also try and save the authenticated_userid if provided, but as I'm not lua guy I would let someone else have a look at that part.