Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router) split paths to properly sort for routing priority #5430

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

locao
Copy link
Contributor

@locao locao commented Jan 10, 2020

Unrelated longer paths were messing with the routing priority, so they must be evaluated alone when choosing by the longest path.

Fix #5418

Unrelated longer paths were messing with the routing priority, so they
must be evaluated alone when choosing by the longest path.
Copy link
Contributor

@hutchic hutchic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test looks correct
it fails when ran against master
it passes when ran against the branch

👍

@hishamhm hishamhm merged commit 49ddba2 into master Jan 10, 2020
@hishamhm hishamhm deleted the fix/longest_path_routing branch January 10, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longest path routing breaks when a route with different host and same path is added
3 participants