fix(ldap-auth) credential rate-limiting and hashing of cache key #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
changed the title
|
Let me know if this can be rebased to |
kikito
requested changes
Jan 24, 2020
bungle
force-pushed
the
fix/ldap-credential-ratelimiting
branch
from
2b2eeff
to
423f845
Compare
p0pr0ck5
reviewed
Jan 24, 2020
bungle
force-pushed
the
fix/ldap-credential-ratelimiting
branch
4 times, most recently
from
2610a3f
to
b9d448c
Compare
### Summary Currently `ldap-auth` does set virtual credential in context on authentication, but that virtual credential does not have `id` which means that rate-limiting plugin cannot rate-limit by the credential, and thus fall-backs to rate-limit by ip. This commit adds `cache_key` as id for that virtual credential. ### Issues Resolved Fix #4129
### Summary Currently `ldap-auth` does seem to use `username` and `password` in a `cache_key` in plain. This is potentially dangerous and may be leaked through it to different places: - memory - admin api - logs This commit fixes that by calling `sha1_bin` on that when generating a cache key. It also drops the use of `md5`.
bungle
force-pushed
the
fix/ldap-credential-ratelimiting
branch
from
5b12ea6
to
460ec5b
Compare
kikito
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(ldap-auth) credential to have id for rate-limiting
Currently
ldap-authdoes set virtual credential in context on authentication, but that virtual credential does not haveidwhich means that rate-limiting plugin cannot rate-limit by the credential, and thus fall-backs to rate-limit by ip.This commit adds
cache_keyas id for that virtual credential.fix(ldap-auth) hash cache key
Currently
ldap-authdoes seem to useusernameandpasswordin acache_keyin plain. This is potentially dangerous and may be leaked through it to different places:This commit fixes that by calling
sha1_binon that when generating a cache key. It also drops the use ofmd5.Issues resolved
Fix #4129