Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat/schemas] API names forbid reserved URI characters #560

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

thibaultcha
Copy link
Member

  • API names cannot contain characters from RFC 3986 reserved characters
    list. If such a character is detected, it is a schema error and the
    creation/update is refused.
  • This also sets an API's name to the given request_path if no
    request_dns is set. The first slash is omitted and subsequent
    slashes are replaced with dashes.
  • Since spaces are not allowed anymore in API names, fixture APIs must
    comply too.

See #547, #489

- API names cannot contain characters from RFC 3986 reserved characters
  list. If such a character is detected, it is a schema error and the
  creation/update is refused.
- This also sets an API's name to the given `request_path` if no
  `request_dns` is set. The first slash is omitted and subsequent
  slashes are replaced with dashes.
- Since spaces are not allowed anymore in API names, fixture APIs must
comply too.

See #547, #489
@thibaultcha thibaultcha changed the title [fea/schemas] API names forbid reserved URI characters [feat/schemas] API names forbid reserved URI characters Sep 22, 2015
@lucamaraschi
Copy link

👍 and the documentation should be updated accordingly

@subnetmarco
Copy link
Member

+1

thibaultcha added a commit that referenced this pull request Sep 23, 2015
[feat/schemas] API names forbid reserved URI characters
@thibaultcha thibaultcha merged commit b7935e3 into master Sep 23, 2015
@thibaultcha thibaultcha deleted the fix/api-name branch September 23, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants