feat(proxy) add route.request|response_buffering #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/unbuffered
branch
5 times, most recently
from
e083bb8
to
674a1d7
Compare
bungle
added
the
pr/discussion
|
So the obvious discussion is: do we want this? |
bungle
force-pushed
the
feat/unbuffered
branch
2 times, most recently
from
03ad1c9
to
d440d3b
Compare
bungle
changed the title
|
@bungle These changes look great. I think adding the property to the route instead of the service is a better fit IMO. Otherwise, users would need to figure out a workaround if they only wanted to modify one route on a service. |
bungle
force-pushed
the
feat/unbuffered
branch
from
d440d3b
to
87ceb20
Compare
bungle
force-pushed
the
feat/unbuffered
branch
3 times, most recently
from
4e5f59d
to
ba40692
Compare
bungle
changed the title
bungle
force-pushed
the
feat/unbuffered
branch
4 times, most recently
from
bb8d4c0
to
e4cecfa
Compare
bungle
removed
the
pr/discussion
bungle
force-pushed
the
feat/unbuffered
branch
from
e4cecfa
to
cd09e0e
Compare
### Summary By default Kong does buffer the request. This is not ideal when proxying bigger payloads with HTTP 1.1 chunked encoding. This commit adds a new property to route entity: ``` request_buffering = <true/false> ``` By default that is `true` (which is the same as before). Users can now turn off the request buffering on route-by-route manner by setting `route.request_buffering=false`.
By default Kong does buffer the response. This is not ideal when upstream is sending payloads with HTTP 1.1 chunked encoding. This commit adds a new property to route entity: ``` response_buffering = <true/false> ``` By default that is `true` (which is the same as before). Users can now turn off the response buffering on route-by-route manner by setting `route.response_buffering=false`.
bungle
force-pushed
the
feat/unbuffered
branch
from
cd09e0e
to
fac1498
Compare
bungle
added
pr/please review
and removed
pr/wip
locao
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Request Buffering
By default Kong does buffer the request. This is not ideal when proxying bigger payloads with HTTP 1.1 chunked encoding.
This PR adds a new property to route entity:
By default that is
true(which is the same as before). Users can now turn the request bufferingoffby route-by-route manner by settingroute.request_buffering=false.Response Buffering
By default Kong does buffer the response. This is not ideal when upstream is sending payloads with HTTP 1.1 chunked encoding.
This PR adds a new property to route entity:
By default that is
true(which is the same as before). Users can now turn off the response buffering on route-by-route manner by settingroute.response_buffering=false.