New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request response route buffering #1011
Conversation
cc51dee
to
fd7781a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My overview omitted details on the tests usually added for these. This should have them also, for annotation extraction and overriding. Examples of those can be found at:
https://github.com/Kong/kubernetes-ingress-controller/blob/1.1.0/internal/ingress/annotations/annotations_test.go#L310-L340 (for extraction)
https://github.com/Kong/kubernetes-ingress-controller/blob/1.1.0/internal/ingress/controller/parser/kongstate/route_test.go#L408-L494 (for annotation overrides) and https://github.com/Kong/kubernetes-ingress-controller/blob/1.1.0/internal/ingress/controller/parser/kongstate/route_test.go#L35-L52 (for KongIngress overrides).
fd7781a
to
f5b000d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 49.56% 49.41% -0.16%
==========================================
Files 32 32
Lines 3198 3224 +26
==========================================
+ Hits 1585 1593 +8
- Misses 1483 1499 +16
- Partials 130 132 +2
Continue to review full report at Codecov.
|
Sorry, I'm still |
I'm going to close this for now because I realize that I have reviewers requested, but this draft is still a work in progress and I don't need review just yet so I don't want anyone to spend time unnecessarily. |
What this PR does / why we need it:
The
request_buffering
andresponse_buffering
options were added in Kong/kong#6057 and enable users to disable buffering for use cases which call for it (namely, large payloads using HTTP 1.1 chunked encoding).This PR adds
request_buffering
andresponse_buffering
options toKongIngress
andIngress
annotations.Which issue this PR fixes
fixes #924
Special notes for your reviewer:
This requires request response route buffering go-kong#15 as is blocked until that lands in a release.WIP
while I'm working on tests