Fixing trailing slash bug #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local response, status = http_client.get(spec_helper.PROXY_URL.."/test-trailing-slash4/request", { hello = "world"}) | ||
| assert.equal(200, status) | ||
| assert.equal("http://www.mockbin.org/request?hello=world", cjson.decode(response).url) | ||
| end) |
There was a problem hiding this comment.
Would be nice if some more use cases could be described in the unit tests too: https://github.com/Mashape/kong/blob/next/spec/unit/core/resolver_spec.lua
subnetmarco
force-pushed
the
fix/trailing-slash
branch
from
0853cd7
to
808daa1
Compare
|
I think this change breaks https://www.ietf.org/rfc/rfc3986.txt which defines that a resource indicator in the html starting without a leading forward slash should be respected as a relative path. The change strip_request_path removing the trailing slash breaks the behaviour described in the RFC 3986. I lost the ability to migrate to latest version of kong because of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #675.