chore(plugins/acme) sync upstream features including Vault K8S auth an… #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MIgrated from Kong/kong-plugin-acme#70 |
fffonion
force-pushed
the
plugins/acme/sync-upstream
branch
from
c5f0b7c
to
a0a67a1
Compare
…d preferred chain selection
fffonion
force-pushed
the
plugins/acme/sync-upstream
branch
from
a0a67a1
to
955cbc4
Compare
kikito
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
I am not super comfortable with this way of adding compatibility, but if that's what we need to do, that's what we need to do.
One small comment, though: this does not look like a feat (it does not add anything that should appear on the "Additions" section of the changelog). It looks more like a chore to me.
|
@kikito Me either. The good part is that the upstream lua-resty-acme library handles those default value |
fffonion
changed the title
|
skipping changelog as this is done for EE compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d preferred
chain selection