feat(pdk) add caching to process secrets function #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Add a little bit of indirection to keep external apis separate from internal ones.
### Summary Just adds config cache to vault process secrets function. Also renames some local variables to make it easier to understand.
### Summary Originally process secrets was meant only to be used on CLI where the cache may not be available (e.g. when parsing `kong.conf`), but we decided later that process secrets could also be used on runtime for config secrets. This commit implements similar caching that is currently enable on config cache function to process secrets function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally process secrets was meant only to be used on CLI where the cache may not be available (e.g. when parsing
kong.conf), but we decided later that process secrets could also be used on runtime for config secrets.This commit implements similar caching that is currently enabled on config cache function to process secrets function.
This also contains two other commits that are just some cleanups and something that I need for rotation implementation.