feat(pdk/db) kong.vault.try function and automatic secret rotation of postgres credentials #8967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/vault-rotation
branch
5 times, most recently
from
b528d6f
to
cc82cf4
Compare
bungle
force-pushed
the
feat/vault-rotation
branch
5 times, most recently
from
7913666
to
d2262da
Compare
bungle
force-pushed
the
feat/vault-rotation
branch
2 times, most recently
from
05c5738
to
4c1cfd3
Compare
bungle
force-pushed
the
feat/vault-rotation
branch
2 times, most recently
from
9052c64
to
f18559a
Compare
jschmid1
reviewed
Jul 7, 2022
bungle
force-pushed
the
feat/vault-rotation
branch
from
f18559a
to
0907db0
Compare
### Summary Adds experimental (for now) kong.vault.try function that can be used to implement automatic secret rotation.
### Summary Adds automatic secret rotation of postgres username and password.
### Summary Adds rate-limiting so that `kong.vault.try` will not call the vault apis everytime it fails with a callback. This will limit concurrency on vault credentials update. The waiting threads wait at maximum 1 second.
bungle
force-pushed
the
feat/vault-rotation
branch
from
0907db0
to
123551b
Compare
jschmid1
approved these changes
Jul 7, 2022
|
Note: we may want to change the way the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains three commits on top of #8966 (which is now merged):