Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external-plugins): handle failing instance creation #9384

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

samugi
Copy link
Member

@samugi samugi commented Sep 6, 2022

Summary

This is a fix for #9301 / FT-3319: when a request made the plugin fail, the creation of a new instance was not handling a failed connection properly.
Upon failure to connect to the socket, it was possible to end up in a state where the instance existed without an instance id,
causing an infinite loop and high CPU utilization.

This is a fix for #9301
when a request made the plugin fail, the creation of a new instance
was not handling a failed connection properly.
Upon failure to connect to the socket, it was possible to end up
in a state where the instance existed without an instance id,
causing an infinite loop and high CPU utilization.
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kikito kikito merged commit 8fb2964 into master Sep 6, 2022
@kikito kikito deleted the fix/pb-rpc-infinite-loop branch September 6, 2022 14:46
samugi added a commit that referenced this pull request Sep 6, 2022
kikito pushed a commit that referenced this pull request Sep 7, 2022
locao pushed a commit that referenced this pull request Jun 21, 2024
…tent_type_parameter_validation` to control content-type parameters validation (#9384)

* feat(plugins/request-validator): added a new configuration field `content_type_parameter_validation` to determine whether to enable Content-Type parameters validation.

* Update kong/clustering/compat/removed_fields.lua

FTI-5979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

100% CPU usage of nginx worker process after custom plugin crash
3 participants