fix(external-plugins): handle failing instance creation #9384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
samugi
force-pushed
the
fix/pb-rpc-infinite-loop
branch
from
1aae791
to
fb6a86b
Compare
This is a fix for #9301 when a request made the plugin fail, the creation of a new instance was not handling a failed connection properly. Upon failure to connect to the socket, it was possible to end up in a state where the instance existed without an instance id, causing an infinite loop and high CPU utilization.
samugi
force-pushed
the
fix/pb-rpc-infinite-loop
branch
from
fb6a86b
to
1442cdd
Compare
samugi
added a commit
that referenced
this pull request
Sep 6, 2022
kikito
pushed a commit
that referenced
this pull request
Sep 7, 2022
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
…tent_type_parameter_validation` to control content-type parameters validation (#9384) * feat(plugins/request-validator): added a new configuration field `content_type_parameter_validation` to determine whether to enable Content-Type parameters validation. * Update kong/clustering/compat/removed_fields.lua FTI-5979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for #9301 / FT-3319: when a request made the plugin fail, the creation of a new instance was not handling a failed connection properly.
Upon failure to connect to the socket, it was possible to end up in a state where the instance existed without an instance id,
causing an infinite loop and high CPU utilization.